Skip to content

PR: from feature/image to aramco#142

Closed
LEEMEJI wants to merge 426 commits into
cloudforet-io:aramcofrom
spaceone-gcp:feature/image
Closed

PR: from feature/image to aramco#142
LEEMEJI wants to merge 426 commits into
cloudforet-io:aramcofrom
spaceone-gcp:feature/image

Conversation

@LEEMEJI
Copy link
Copy Markdown

@LEEMEJI LEEMEJI commented Nov 10, 2025

Bugfix-GCP-INVEN-018-003 > Networking > LoadBalancing > 목록 테이블 중복필드

  • What: spaceONE의 Networking > LoadBalancing
  • Why: 통합 테스트 중 오류 발결
  • Impact: Networking > LoadBalancing > Table

Bugfix-GCP-INVEN-018-004 > Networking > LoadBalancing > 목록 테이블 데이터 미노출

  • What: spaceONE의 Networking > LoadBalancing
  • Why: 통합 테스트 중 오류 발결
  • Impact: Networking > LoadBalancing > Table

Bugfix-GCP-INVEN-018-006 > Networking > LoadBalancing > GCP 콘솔 상세 화면 이동불가

  • What: spaceONE의 Networking > LoadBalancing
  • Why: 통합 테스트 중 오류 발결
  • Impact: Networking > LoadBalancing > connect to console button

Bugfix-GCP-INVEN-018-010 > Networking > LoadBalancing > Forwarding Rule 탭 데이터 불일치

  • What: spaceONE의 Networking > LoadBalancing
  • Why: 통합 테스트 중 오류 발결
  • Impact: Networking > LoadBalancing > Forwarding Rule 탭

Bugfix-GCP-INVEN-018-012 > Networking > LoadBalancing > UrlMap 탭 데이터 미노출

  • What: spaceONE의 Networking > LoadBalancing
  • Why: 통합 테스트 중 오류 발결
  • Impact: Networking > LoadBalancing > UrlMap 탭

Bugfix-GCP-INVEN-018-013 > Networking > LoadBalancing > Backend Service 탭 데이터 미노출

  • What: spaceONE의 Networking > LoadBalancing
  • Why: 통합 테스트 중 오류 발결
  • Impact: Networking > LoadBalancing > Backend Service 탭

Bugfix-GCP-INVEN-018-016 > Networking > LoadBalancing > Health Check 탭 데이터 미노출

  • What: spaceONE의 Networking > LoadBalancing
  • Why: 통합 테스트 중 오류 발결
  • Impact: Networking > LoadBalancing > Health Check 탭

mzljieun and others added 30 commits September 8, 2025 22:29
chore(cloud run, cloud build, dataproc): update data format
chore(cloud run, cloud build, dataproc): update data format
…v2 location + build, trigger, connection 2. Cloud Run v2 : v1 location + service, job, wokerpool)
spaceone-gcp and others added 26 commits November 10, 2025 16:21
- Remove Tags table layout that referenced data.config.tags (network tags)
- Network tags are Compute Engine firewall tags, not user-friendly resource labels
- NodePool labels are already converted to SpaceONE tags format for proper resource tagging
- Simplify UI by removing confusing network tags section that provides little value to users

The Tags section showed Compute Engine network tags (for firewall rules) which are typically
empty or contain technical network identifiers, not user-meaningful resource tags.
Resource labels are properly handled through the SpaceONE tags system.
- Change OAuth Scopes from TableDynamicLayout to ItemDynamicLayout with ListDyField
- Use outline badges with line break delimiter for better readability
- Follow same pattern as Compute Engine instance templates for scope display
- Maintain OAuth Scopes section as it contains important security/permission information
- Add ListDyField import for enhanced list display functionality

OAuth Scopes define the Google Cloud API access permissions for GKE nodes,
which is crucial security information that should be easily visible to users.
…fields from NodePool

- Remove create_time and update_time fields from NodePool data model
- Remove Created and Updated fields from NodePool UI (cloud_service_type.py)
- Remove corresponding search fields for datetime filtering
- Remove field processing from node_pool_v1beta_manager.py
- Clean up unused DateTimeDyField import

These fields were not provided by the GKE NodePool API (v1/v1beta1) and contained no data.
GKE NodePool API does not include createTime/updateTime in its response, unlike other GCP resources.
This cleanup improves UI clarity by removing empty/unused fields.
- Fix unmatched '}' syntax error in data.py reference method
- Remove duplicate CLOUD_SERVICE_TYPES export section in cloud_service_type.py
- Improve import organization and code formatting
- Add missing newline at end of data.py file

These syntax errors were preventing the NodePool manager from loading properly.
…odePool

- Fix regional instance group lookup to query at region level instead of individual zones
- Extract zone information from instance metadata for proper node info
- Reduce log noise by changing INFO to DEBUG for expected 404 errors
- Remove unused vm_connector variable to clean up code
- Improve error handling for regional vs zonal instance groups

This resolves 404 errors when trying to find zonal instance groups in regional clusters.
Regional instance groups should be queried directly at the region level, not zone by zone.
- Format zone extraction logic with proper line breaks for better readability
- Improve import statement formatting in data.py with proper multi-line structure
- Add consistent spacing and line breaks in NodePool model class
- Enhance code readability while maintaining functionality

These changes improve code style consistency following Python formatting standards.
- Minor formatting improvements in cloud_service_conf.py
- Enhance code structure and readability in app_engine/instance_v1_manager.py
- Apply consistent formatting standards across the codebase

These changes improve overall code quality and maintainability.
PR: from Feature/julia to aramco - Bugfix-KubernetesClusters
- 실제 API 응답에 포함되지 않는 api_version 필드를 모든 Kubernetes Engine 관련 파일에서 제거
- Manager 파일에서 api_version 데이터 추가 코드 삭제
- 테이블 및 상세 테이블에서 API Version 필드 표시 제거
- 검색 필드에서도 API Version 제거
- 데이터 모델에서 api_version 필드 정의 삭제
- v1과 v1beta1 모두 동일하게 적용

변경된 파일:
- Manager: cluster_v1, cluster_v1beta, node_pool_v1, node_pool_v1beta
- Model: cluster/cloud_service, cluster/cloud_service_type, cluster/data
- Model: node_pool/cloud_service_type, node_pool/data
- 테이블 뷰에서 Fleet Info, Membership Info, Resource Limits Count 필드 제거
- 검색 필드에서도 해당 필드들 제거
- UI에서 불필요한 정보 노출 방지

변경된 파일:
- cluster/cloud_service_type.py: 테이블 필드 및 검색 필드 제거
- 노드풀 정보를 기반으로 클러스터의 총 CPU와 메모리 계산 기능 구현
- 주요 GCP 머신 타입(n1, n2, e2 시리즈) 스펙 매핑 테이블 추가
- 알 수 없는 머신 타입에 대한 추정 로직 구현
- 테이블 뷰에 '총 vCPU', '총 메모리' 필드 추가
- 검색 필드에도 Total CPU, Total Memory 추가

변경된 파일:
- cluster_v1_manager.py: calculate_cluster_resources 메서드 추가
- cluster_v1beta_manager.py: calculate_cluster_resources 메서드 추가
- cluster/data.py: GKECluster 모델에 total_cpu, total_memory_gb 필드 추가
- cluster/cloud_service_type.py: 테이블 및 검색 필드 추가

기능:
- 각 노드풀의 머신 타입과 노드 수를 기반으로 총 리소스 계산
- 표준/고메모리/고CPU 머신 타입별 정확한 스펙 적용
- 파싱 불가능한 머신 타입에 대한 추정 로직 제공
- calculate_cluster_resources 메서드의 코드 포맷팅 개선
- 긴 줄을 적절히 분할하여 가독성 향상
- import 문 포맷팅 개선
- trailing comma 추가로 일관성 유지
…Rules 필드 제거

- cloud_service_type.py에서 테이블 표시용 필드 3개 제거
- 상세 탭(Feature Settings, IAP Settings, Dispatch Rules)은 유지
- 데이터 모델과 API 매핑 로직은 그대로 유지
- 테이블 영역에서만 해당 필드들이 보이지 않도록 수정
- cloud_service_type.py에서 Instance ID 테이블 필드 제거
- Instance ID 검색 필드도 함께 제거
- 상세 페이지에서는 여전히 Instance ID 확인 가능
- 테이블 목록에서만 Instance ID가 보이지 않도록 수정
- Service ID와 Version ID를 테이블 첫 번째, 두 번째 필드로 이동
- Instance ID 제거 후 Service ID, Version ID가 주요 식별자 역할
- 테이블에서 인스턴스 식별이 더 명확하도록 필드 순서 최적화

필드 순서 (변경 후):
1. Service ID
2. Version ID
3. QPS
4. Latency
5. Requests
6. Errors
7. Memory (MB)
8. Start Time
9. Availability
10. VM Status
11. App Engine Release
12. Created
- cloud_service_type.py에서 Service 테이블 필드 제거
- Service 검색 필드도 함께 제거
- 중복된 CLOUD_SERVICE_TYPES 정의 정리
- Service ID가 첫 번째 필드로 변경되어 서비스 식별 가능
- 상세 페이지에서는 여전히 Service 이름 확인 가능

필드 순서 (변경 후):
1. Service ID (첫 번째 필드로 변경)
2. Serving Status
3. Versions
4. Instance Count
5. Labels
6. VPC Access Name
7. VPC Egress Setting
8. Last Version Deployed
…드 제거

- Labels, VPC Access Name, VPC Egress Setting 테이블 필드 제거
- 해당 검색 필드들도 함께 제거
- 테이블 간소화로 핵심 정보에 집중
- 상세 페이지의 전용 탭에서는 여전히 확인 가능

최적화된 테이블 필드 (변경 후):
1. Service ID
2. Serving Status
3. Versions
4. Instance Count
5. Last Version Deployed

제거 이유:
- VPC 미사용 서비스에서 빈 필드 발생
- Labels는 복잡한 메타데이터로 테이블 가독성 저하
- 상세 정보는 전용 탭에서 접근 가능
PR: from Feature/cylim to aramco / Bugfix-Filestore
@github-actions
Copy link
Copy Markdown

⚠️ @LEEMEJI the signed-off-by was not found in the following 30 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

1 similar comment
@github-actions
Copy link
Copy Markdown

⚠️ @LEEMEJI the signed-off-by was not found in the following 30 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants